Re: student requesting critique

by "Tim Rivera" <lists(at)timrivera.com>

 Date:  Tue, 22 Apr 2003 23:52:09 -0400
 To:  "Meahl,
Darren" <meahl(at)mail.lib.msu.edu>,
<hwg-critique(at)hwg.org>
 References:  msu
  todo: View Thread, Original
> http://www.lib.msu.edu/events/MSUAlumni/MSUAlumIndex.html


First off, you should validate the page. Why have the W3C icon on a page that
doesn't validate? You need to escape the "&" character in one of the links
with "&amp;". Also, the 'target' attribute is not present in the Strict DTD,
only Transitional.

Okay, I just saw your comment in the HTML about not being allowed to change
that URL. Well you'll be happy to know that escaping the ampersand will not
change the URL.


To center the second table in browsers other than IE, give the table an "auto"
margin via CSS; what's important is the left and right margin (I'll go with
what you have and include it in the 'style' attribute):
    <table style="margin: auto; font-family: .." width="45%;"

Also, you need to remove the semicolon from the value of 'width' in both
tables.


I noticed that the icons at the bottom of the page have a blue border in IE
and Mozilla; you should remove this via CSS.
    img {border: none}

Also, there is a little blue line next to the icons because you have white
space (a line break) between the image and the closing anchor tag.


You use multiple BR's, P's, and &nbsp;'s, when it would be better to use CSS
to declare the desired margin or padding. IMO, you should use relative URLs
rather than absolute. Oh, and the name of this file should be just index.html.
It is common practice to name the main page of a directory index.html, that
way you don't even need to specify the file name, just the directory, as in
http://www.lib.msu.edu/events/MSUAlumni/. Now that gives me a list of every
file in the directory.


Otherwise, the page looks good. You are doing a good job. I am glad you are
taking the time to try to learn HTML right, and are concerned about having
valid markup. Good luck to you!


Tim
____________________________________________________________
http://webdesign.meetup.com/     See you at the next meetup!

HTML: hwg-critique mailing list archives, maintained by Webmaster @ IWA